Add static cache for edd_get_option()
#9744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to get orders calls and respect order currency awesomemotive#9484
Add current page to edd_global_vars, include in tax recalculation
Update block editor author selection for download capabilities
Update edd_is_checkout logic
Co-authored-by: Žan K. <[email protected]>
Limit the product_dropdown calls on the logs and main tools page to use chosen awesomemotive#9498
Add a permalink value to the products endpoint awesomemotive#9488
Adding release 3.2.2 changes
Adding EDD 3.2.4 changes
Adding EDD 3.2.10
Adding EDD 3.2.11
Adding 3.2.12 changes
|
This is trading CPU for memory, which is ok. But there should be a limit to the cache size or there's trouble ahead. |
Contributor
|
Thanks @zackkatz. I'll have a look at the suggestion here and see what we can come up with. I agree that there is some precedence set that the filter will be run every time the option is getting requested...so only running the filter a single time may be a problem, but I'll see what we can do here. I agree with @mbtools here that it's a trade in the direction of memory over CPU, which is usually a good tradeoff (but should be capped for sure). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9743
Proposed Changes:
edd_get_option()to improve speed.